[PATCH] D138473: clang/HIP: Inline frexp/frexpf implementations

arsenm closed this revision. arsenm added a comment. e1fa30d005afa32be1a8d490e99652cd56440826 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138473/new/ https://reviews.llvm.org/D138473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D138473: clang/HIP: Inline frexp/frexpf implementations

arsenm added a comment. Herald added a subscriber: jplehr. After D149716 this can switch to use the new builtin, and thus restores the ye olde southern islands workaround CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138473/new/ https://reviews.llvm.o

[PATCH] D138473: clang/HIP: Inline frexp/frexpf implementations

arsenm added a comment. In D138473#3944586 , @yaxunl wrote: > Are you sure these functions are equivalent? we do not have a comprehensive > test for these functions regarding accuracy. These are ultimately simple bit extracts. The library implementation

[PATCH] D138473: clang/HIP: Inline frexp/frexpf implementations

yaxunl added a comment. Are you sure these functions are equivalent? we do not have a comprehensive test for these functions regarding accuracy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138473/new/ https://reviews.llvm.org/D138473 ___ c

[PATCH] D138473: clang/HIP: Inline frexp/frexpf implementations

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Noisy diff! Getting rid of the openmp special case handling here is nice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138473/new/ https://reviews.llvm.org/D138473