[PATCH] D138466: Don't use Optional::getPointer (NFC)

2022-11-21 Thread Kazu Hirata via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f914944b6c9: Don't use Optional::getPointer (NFC) (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D138466: Don't use Optional::getPointer (NFC)

2022-11-21 Thread Kazu Hirata via Phabricator via cfe-commits
kazu added a comment. Thanks for the review! In D138466#3942622 , @MaskRay wrote: > `getPointer` asserts `hasValue`, so `&*` is safe, Yes. `operator*` also asserts `hasVal` via `value()`, so we maintain the same level of safety. Repository: rG LLV

[PATCH] D138466: Don't use Optional::getPointer (NFC)

2022-11-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. `getPointer` asserts `hasValue`, so `&*` is safe, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138466/new/ https://reviews.llvm.org/D138466

[PATCH] D138466: Don't use Optional::getPointer (NFC)

2022-11-21 Thread Kazu Hirata via Phabricator via cfe-commits
kazu created this revision. Herald added subscribers: kadircet, arphaman, javed.absar, hiraditya. Herald added a project: All. kazu requested review of this revision. Herald added projects: clang, LLVM, clang-tools-extra. Herald added subscribers: cfe-commits, llvm-commits. Since std::optional doe