[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

2022-11-30 Thread Gong LingQin via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG624401612c3a: [LoongArch] Add remaining intrinsics for CRC check instructions (authored by gonglingqin). Changed prior to commit: https://reviews.

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

2022-11-27 Thread Lu Weining via Phabricator via cfe-commits
SixWeining added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:925 llvm_unreachable("Unexpected Intrinsic."); -case Intrinsic::loongarch_crc_w_d_w: { - Results.push_back(DAG.getNode( - ISD::TRUNCATE, DL, N->getValueType(

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

2022-11-22 Thread Lu Weining via Phabricator via cfe-commits
SixWeining added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:925 llvm_unreachable("Unexpected Intrinsic."); -case Intrinsic::loongarch_crc_w_d_w: { - Results.push_back(DAG.getNode( - ISD::TRUNCATE, DL, N->getValueType(

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

2022-11-22 Thread Gong LingQin via Phabricator via cfe-commits
gonglingqin updated this revision to Diff 477393. gonglingqin added a comment. Address @xen0n's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138418/new/ https://reviews.llvm.org/D138418 Files: clang/include/clang/Basic/BuiltinsLoongAr

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

2022-11-22 Thread Gong LingQin via Phabricator via cfe-commits
gonglingqin added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:925 llvm_unreachable("Unexpected Intrinsic."); -case Intrinsic::loongarch_crc_w_d_w: { - Results.push_back(DAG.getNode( - ISD::TRUNCATE, DL, N->getValueType

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

2022-11-22 Thread WÁNG Xuěruì via Phabricator via cfe-commits
xen0n added a comment. otherwise LGTM Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:925 llvm_unreachable("Unexpected Intrinsic."); -case Intrinsic::loongarch_crc_w_d_w: { - Results.push_back(DAG.getNode( - ISD::TRUNCATE, DL, N->getValu

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

2022-11-22 Thread Gong LingQin via Phabricator via cfe-commits
gonglingqin updated this revision to Diff 477382. gonglingqin added a comment. Address @SixWeining's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138418/new/ https://reviews.llvm.org/D138418 Files: clang/include/clang/Basic/BuiltinsLo

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

2022-11-22 Thread Gong LingQin via Phabricator via cfe-commits
gonglingqin added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:925 llvm_unreachable("Unexpected Intrinsic."); -case Intrinsic::loongarch_crc_w_d_w: { - Results.push_back(DAG.getNode( - ISD::TRUNCATE, DL, N->getValueType

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

2022-11-22 Thread Lu Weining via Phabricator via cfe-commits
SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:925 llvm_unreachable("Unexpected Intrinsic."); -case Intrinsic::loongarch_crc_w_d_w:

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

2022-11-22 Thread Gong LingQin via Phabricator via cfe-commits
gonglingqin updated this revision to Diff 477363. gonglingqin added a comment. Address @SixWeining's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138418/new/ https://reviews.llvm.org/D138418 Files: clang/include/clang/Basic/BuiltinsLo

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

2022-11-22 Thread Lu Weining via Phabricator via cfe-commits
SixWeining added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:925-933 +case Intrinsic::loongarch_crc_w_b_w: { + Results.push_back(DAG.getNode( + ISD::TRUNCATE, DL, VT, + DAG.getNode(LoongArchISD::CRC_W_B_W, DL, MVT::i

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

2022-11-21 Thread Gong LingQin via Phabricator via cfe-commits
gonglingqin created this revision. gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay, XiaodongLoong. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. gonglingqin requested review of this revision. Herald added projects: clang, LLVM. Herald adde