This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
HazardyKnusperkeks marked an inline comment as done.
Closed by commit rGce7356f08194: [clang-format] Don't eat two semicolons
after namespace (authored by HazardyKnuspe
Herald added a comment.
NOTE: Clang-Format Team Automated Review Comment
It looks like your clang-format review does not contain any unit tests, please
try to ensure all code changes have a unit test (unless this is an `NFC` or
refactoring, adding documentation etc..)
Add your unit tests in `c
MyDeveloperDay added inline comments.
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2999
-// Munch the semicolon after a namespace. This is more common than one
would
-// think. Putting the semicolon into its own line is very ugly.
This comment
MyDeveloperDay accepted this revision.
MyDeveloperDay added a comment.
This revision is now accepted and ready to land.
Feels like this would only show if someone did
namespace A {
};;
Which seems odd
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.o
HazardyKnusperkeks added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138373/new/
https://reviews.llvm.org/D138373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.l
HazardyKnusperkeks created this revision.
HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, rymiel.
HazardyKnusperkeks added a project: clang-format.
Herald added a project: All.
HazardyKnusperkeks requested review of this revision.
Herald added a project: clang.
Herald added a subscribe
