[PATCH] D138371: [clang-format] Fix a crash due to dereferencing null MatchingParen

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4daeb8c73354: [clang-format] Fix a crash due to dereferencing null MatchingParen (authored by owenpan). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D138371: [clang-format] Fix a crash due to dereferencing null MatchingParen

rymiel added a comment. In D138371#3939938 , @HazardyKnusperkeks wrote: > In D138371#3939682 , @rymiel wrote: > >> Oops, nevermind, I misunderstood the loop > > To understand this is really a tough one. Took me s

[PATCH] D138371: [clang-format] Fix a crash due to dereferencing null MatchingParen

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D138371#3939682 , @rymiel wrote: > Oops, nevermind, I misunderstood the loop To understand this is really a tough one. Took

[PATCH] D138371: [clang-format] Fix a crash due to dereferencing null MatchingParen

rymiel added a comment. Oops, nevermind, I misunderstood the loop CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138371/new/ https://reviews.llvm.org/D138371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D138371: [clang-format] Fix a crash due to dereferencing null MatchingParen

rymiel added a comment. Could the check be hoisted to the top of the loop? could that possibly catch more cases? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138371/new/ https://reviews.llvm.org/D138371 ___ cfe-commits mailing list cfe-comm

[PATCH] D138371: [clang-format] Fix a crash due to dereferencing null MatchingParen

owenpan updated this revision to Diff 476719. owenpan added a comment. Added a test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138371/new/ https://reviews.llvm.org/D138371 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp Index: clang/unitt

[PATCH] D138371: [clang-format] Fix a crash due to dereferencing null MatchingParen

owenpan created this revision. owenpan added reviewers: HazardyKnusperkeks, MyDeveloperDay, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://gi