This revision was automatically updated to reflect the committed changes.
Closed by commit rL253405: Produce a better diagnostic for global register
variables. (authored by ahatanak).
Changed prior to commit:
http://reviews.llvm.org/D13834?vs=39774&id=40451#toc
Repository:
rL LLVM
http://re
ahatanak added a comment.
Thanks, I'll commit this patch shortly.
If it makes the code cleaner, I can define enums in TargetInfo and change
validateGlobalRegisterVariable to return one of them in a follow-up patch.
http://reviews.llvm.org/D13834
_
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM.
Thanks!
-eric
http://reviews.llvm.org/D13834
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
ahatanak updated this revision to Diff 39774.
ahatanak added a comment.
Added comments to clarify what the code is doing.
http://reviews.llvm.org/D13834
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Basic/TargetInfo.h
lib/Basic/Targets.cpp
lib/Sema/SemaDecl.cpp
test/
echristo added a comment.
My preference for this sort of thing would be an enum of failure reasons, but I
guess this is ok for now. One inline request.
-eric
Comment at: lib/Basic/Targets.cpp:3978-3981
@@ +3977,6 @@
+ bool &HasSizeMismatch)
ping
On Fri, Oct 16, 2015 at 2:51 PM, Akira Hatanaka wrote:
> ahatanak created this revision.
> ahatanak added a subscriber: cfe-commits.
>
> clang doesn't print a very user-friendly message when an invalid register
> is used for a global register variable:
>
> For example, when the following co
ahatanak created this revision.
ahatanak added a subscriber: cfe-commits.
clang doesn't print a very user-friendly message when an invalid register is
used for a global register variable:
For example, when the following code is compiled,
$ cat f1.c
volatile register long long A asm ("rdi");
vo
