This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG04202b94b684: [-Wunsafe-buffer-usage] Improve pointer
matching pattern (authored by ziqingluo-90).
Changed prior to commit:
https://reviews.llvm.o
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Great!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138318/new/
https://reviews.llvm.org/D138318
___
cfe-commits mailing list
cfe-commits@lists
ziqingluo-90 updated this revision to Diff 483658.
ziqingluo-90 added a comment.
Addressing comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138318/new/
https://reviews.llvm.org/D138318
Files:
clang/lib/Analysis/UnsafeBufferUsage.cpp
clang/test/SemaCXX/warn-unsafe-buffer-usa
ziqingluo-90 added inline comments.
Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:30-39
+ return anyOf(
+hasType(pointerType()),
+hasType(autoType(
+hasDeducedType(hasUnqualifiedDesugaredType(pointerType(),
+// DecayedType, e.g., array type in
aaron.ballman added inline comments.
Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:31
+ return anyOf(
+hasType(pointerType()),
+hasType(autoType(
I shudder to ask this question, but ... pointer to member types?
Comment at: clang
ziqingluo-90 added inline comments.
Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:31-39
+hasType(pointerType()),
+hasType(autoType(
+hasDeducedType(hasUnqualifiedDesugaredType(pointerType(),
+// DecayedType, e.g., array type in formal parameter
ziqingluo-90 updated this revision to Diff 478341.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138318/new/
https://reviews.llvm.org/D138318
Files:
clang/lib/Analysis/UnsafeBufferUsage.cpp
clang/test/SemaCXX/warn-unsafe-buffer-usage.cpp
Index: clang/test/SemaCXX/warn-unsafe-buffer-
xazax.hun added inline comments.
Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:31-39
+hasType(pointerType()),
+hasType(autoType(
+hasDeducedType(hasUnqualifiedDesugaredType(pointerType(),
+// DecayedType, e.g., array type in formal parameter dec
ziqingluo-90 updated this revision to Diff 476578.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138318/new/
https://reviews.llvm.org/D138318
Files:
clang/lib/Analysis/UnsafeBufferUsage.cpp
clang/test/SemaCXX/warn-unsafe-buffer-usage.cpp
Index: clang/test/SemaCXX/warn-unsafe-buffer-
ziqingluo-90 created this revision.
ziqingluo-90 added reviewers: NoQ, jkorous, t-rasmud, malavikasamak,
aaron.ballman, gribozavr, xazax.hun.
Herald added a subscriber: rnkovacs.
Herald added a project: All.
ziqingluo-90 requested review of this revision.
Herald added a project: clang.
Herald adde
10 matches
Mail list logo