[PATCH] D138289: [clang][Parse] Remove constant expression from if condition

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a1c192bd6bf: [clang][Parse] Remove constant expression from if co

[PATCH] D138289: [clang][Parse] Remove constant expression from if condition

aaron.ballman added a comment. In D138289#3943090 , @tbaeder wrote: > Yeah, just removing the `MaybeTypeCast` worked, but switching to `isTypeCast` > doens't. I think for now we can remove the `MaybeTypeCast` entirely. We only set `isTypeCast` once we

[PATCH] D138289: [clang][Parse] Remove constant expression from if condition

tbaeder added a comment. Yeah, just removing the `MaybeTypeCast` worked, but switching to `isTypeCast` doens't. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138289/new/ https://reviews.llvm.org/D138289 ___ cfe-commits mailing list cfe-commi

[PATCH] D138289: [clang][Parse] Remove constant expression from if condition

aaron.ballman added a comment. Precommit CI found that this change breaks clang/test/Sema/PR28181.c which was introduced to fix https://bugs.llvm.org/show_bug.cgi?id=28181 which was a regression caused by https://github.com/llvm/llvm-project/commit/5a5319062300166a747807339349766341a2c2b2 CHA

[PATCH] D138289: [clang][Parse] Remove constant expression from if condition

tbaeder updated this revision to Diff 476452. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138289/new/ https://reviews.llvm.org/D138289 Files: clang/lib/Parse/ParseExpr.cpp Index: clang/lib/Parse/ParseExpr.cpp === --- c

[PATCH] D138289: [clang][Parse] Remove constant expression from if condition

aaron.ballman added a comment. This code was introduced in https://github.com/llvm/llvm-project/commit/5a5319062300166a747807339349766341a2c2b2 and does not appear to have had precommit review (that I could find). It was resolving https://bugs.llvm.org/show_bug.cgi?id=23101, and the last commen

[PATCH] D138289: [clang][Parse] Remove constant expression from if condition

tbaeder created this revision. tbaeder added a reviewer: clang. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `MaybeTypeCast` here is not a variable, it's an enum member with value 1. I'm just not sur