[PATCH] D138278: TableGen: honor LLVM_LINK_LLVM_DYLIB by default

2023-06-19 Thread Tobias Grosser via Phabricator via cfe-commits
grosser added a comment. That is perfectly fine. I just wanted to let you know that we are still interested in this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138278/new/ https://reviews.llvm.org/D138278 __

[PATCH] D138278: TableGen: honor LLVM_LINK_LLVM_DYLIB by default

2023-06-19 Thread Nicolai Hähnle via Phabricator via cfe-commits
nhaehnle added a comment. Herald added a subscriber: wangpc. I haven't looked at this in a while, sorry. I do plan to cycle back to it eventually, but right now my work scheduling is more stack-based than FIFO and this is fairly low down... Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D138278: TableGen: honor LLVM_LINK_LLVM_DYLIB by default

2023-05-27 Thread Tobias Grosser via Phabricator via cfe-commits
grosser added a comment. Herald added subscribers: bviyer, asb. @nhaehnle, I wanted to check in briefly if you are getting the same error messages? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138278/new/ https://reviews.llvm.org/D138278 ___

[PATCH] D138278: TableGen: honor LLVM_LINK_LLVM_DYLIB by default

2022-11-21 Thread Tobias Grosser via Phabricator via cfe-commits
grosser added a comment. I just checked and I get the same error on a linux system. @nhaehnle, did you try an mlir build with the previously mentioned cmake options? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138278/new/ https://reviews.llvm.or

[PATCH] D138278: TableGen: honor LLVM_LINK_LLVM_DYLIB by default

2022-11-21 Thread Tobias Grosser via Phabricator via cfe-commits
grosser added a comment. This patch overcomes the issue of cl options being defined multiple times. That is great! I just tried it on Windows on top of e7fb6c394f519d6e6812f1fbbff1571d5e51f5c4 with (msys2), as well as LLVM_L

[PATCH] D138278: TableGen: honor LLVM_LINK_LLVM_DYLIB by default

2022-11-18 Thread Stephen Neuendorffer via Phabricator via cfe-commits
stephenneuendorffer added a comment. I think the MLIR parts of this code were written before attempting to create libMLIR.so. Probably these tablegen binaries would have to also avoid linking against libMLIR.so and be statically linked to both llvmSupport and MLIRsupport to work properly.I

[PATCH] D138278: TableGen: honor LLVM_LINK_LLVM_DYLIB by default

2022-11-18 Thread Nicolai Hähnle via Phabricator via cfe-commits
nhaehnle created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini,