This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG86278114085b: [clang-format] Support new file formatting
with vim (authored by jsji).
Changed prior to commit:
https://reviews.llvm.org/D138234?vs
owenpan accepted this revision.
owenpan added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138234/new/
https://reviews.llvm.org/D138234
_
jsji updated this revision to Diff 476905.
jsji added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138234/new/
https://reviews.llvm.org/D138234
Files:
clang/tools/clang-format/clang-format.py
Index: clang/tools/cl
owenpan added inline comments.
Comment at: clang/tools/clang-format/clang-format.py:48
import vim
+import os.path
Can you move it up to keep the module names sorted?
Comment at: clang/tools/clang-format/clang-format.py:80
lines = ['-lin
jsji created this revision.
jsji added reviewers: djasper, klimek.
Herald added a project: All.
jsji requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The vim Formatonsave integration is not working if we create a new file
directly using vim
