[PATCH] D138207: [clang][Parse][NFC] Remove unused CommaLocs parameters

2022-11-18 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder closed this revision. tbaeder added a comment. Dang, looks like I forgot to mention the review in https://github.com/llvm/llvm-project/commit/e78a43dacafb8b97fc377a52f8f206e37d94d5d6. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138207/new

[PATCH] D138207: [clang][Parse][NFC] Remove unused CommaLocs parameters

2022-11-17 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM -- it's a bit sad that we're losing some assertion coverage, but it seems like reasonable coverage to lose. Comment at: clang/include/clang/Parse/Parser.h

[PATCH] D138207: [clang][Parse][NFC] Remove unused CommaLocs parameters

2022-11-17 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added a reviewer: clang. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The vectors holding the comma locs are unused (except for an assertion in two places). R