shafik added inline comments.
Comment at: clang/lib/Parse/ParseStmt.cpp:1286
if (getLangOpts().CPlusPlus) {
-Cond = ParseCXXCondition(InitStmt, Loc, CK, MissingOK);
+Cond = ParseCXXCondition(InitStmt, Loc, CK, false);
} else {
Nitpick edit for addin
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9f6147900739: [clang][Parser][NFC] Simplify
ParseParenExprOrCondition (authored by tbaeder).
Changed prior to commit:
https://reviews.llvm.org/D13
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a minor improvement.
Comment at: clang/lib/Parse/ParseStmt.cpp:1275-1282
bool Parser::ParseParenExprOrCondition(StmtResult *InitStmt,
tbaeder created this revision.
tbaeder added a reviewer: clang.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D138194
Files:
clang/inc
