[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

2022-12-18 Thread YunQiang Su via Phabricator via cfe-commits
wzssyqa added a comment. https://reviews.llvm.org/D140270 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138179/new/ https://reviews.llvm.org/D138179 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

2022-12-18 Thread YunQiang Su via Phabricator via cfe-commits
wzssyqa added a comment. In D138179#4002068 , @nathanchance wrote: > For what it's worth, this breaks building the Linux kernel's `ARCH=mips > 32r1_defconfig` with clang and GNU as, with thousands of messages along the > line of: > > /tmp/mmc_ops-d32

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

2022-12-16 Thread Nathan Chancellor via Phabricator via cfe-commits
nathanchance added subscribers: nickdesaulniers, nathanchance. nathanchance added a comment. For what it's worth, this breaks building the Linux kernel's `ARCH=mips 32r1_defconfig` with clang and GNU as, with thousands of messages along the line of: /tmp/mmc_ops-d329c3.s: Assembler messages:

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

2022-12-15 Thread Fangrui Song via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9739bb81aed4: MIPS: fix build from IR files, nan2008 and FpAbi (authored by wzssyqa, committed by MaskRay). Repository: rG LLVM Github Monorepo C

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

2022-12-15 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. (On a trip so I will be slow.) I wish that some mips experts like @atanasyan can some proper checks but this patch seems fine. Landing in one minute after testing finishes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138179/new/ https://reviews.llvm.org/D138

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

2022-12-14 Thread YunQiang Su via Phabricator via cfe-commits
wzssyqa added a comment. ahhh, ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138179/new/ https://reviews.llvm.org/D138179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

2022-11-19 Thread YunQiang Su via Phabricator via cfe-commits
wzssyqa updated this revision to Diff 476716. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138179/new/ https://reviews.llvm.org/D138179 Files: clang/lib/Driver/ToolChains/Arch/Mips.cpp clang/test/Driver/mips-as.c clang/test/Driver/mips-integrated-as.s llvm/lib/Target/Mips/MipsAs

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

2022-11-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added inline comments. Comment at: llvm/lib/Target/Mips/MipsAsmPrinter.cpp:402 MipsTargetStreamer &TS = getTargetStreamer(); + const MipsTargetMachine &MTM = static_cast(TM); delete blank line Comme

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

2022-11-17 Thread YunQiang Su via Phabricator via cfe-commits
wzssyqa updated this revision to Diff 476303. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138179/new/ https://reviews.llvm.org/D138179 Files: clang/lib/Driver/ToolChains/Arch/Mips.cpp clang/test/Driver/mips-as.c clang/test/Driver/mips-integrated-as.s llvm/lib/Target/Mips/MipsAs

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

2022-11-17 Thread YunQiang Su via Phabricator via cfe-commits
wzssyqa updated this revision to Diff 476302. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138179/new/ https://reviews.llvm.org/D138179 Files: clang/lib/Driver/ToolChains/Arch/Mips.cpp clang/test/Driver/mips-as.c clang/test/Driver/mips-integrated-as.s llvm/lib/Target/Mips/MipsAs

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

2022-11-17 Thread YunQiang Su via Phabricator via cfe-commits
wzssyqa added a comment. In D138179#3934543 , @MaskRay wrote: > Rubber stamp. I try to find some mips folks who can verify, so maybe wait a > day or so. > >> When we use llc or lld to compiler IR files, the features +nan2008 and >> +fpxx/+fp64 are not u

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

2022-11-17 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Rubber stamp. I try to find some mips folks who can verify, so maybe wait a day or so. > When we use llc or lld to compiler IR files, the features +nan2008 and > +fpxx/+fp64 are not used. T

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

2022-11-17 Thread YunQiang Su via Phabricator via cfe-commits
wzssyqa updated this revision to Diff 476039. wzssyqa added a comment. Add llvm/test/CodeGen/Mips/abiflags-2008-fp64.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138179/new/ https://reviews.llvm.org/D138179 Files: clang/lib/Driver/ToolChains

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

2022-11-17 Thread YunQiang Su via Phabricator via cfe-commits
wzssyqa updated this revision to Diff 476033. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138179/new/ https://reviews.llvm.org/D138179 Files: clang/lib/Driver/ToolChains/Arch/Mips.cpp clang/test/Driver/mips-as.c clang/test/Driver/mips-integr

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

2022-11-16 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138179/new/ https://reviews.llvm.org/D138179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

2022-11-16 Thread YunQiang Su via Phabricator via cfe-commits
wzssyqa created this revision. wzssyqa added reviewers: MaskRay, atanasyan. Herald added subscribers: StephenFan, jrtc27, hiraditya, arichardson, sdardis. Herald added a project: All. wzssyqa requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commi