[PATCH] D138159: [Clang][OpenMP] Add enter clause to declare target for OpenMP 5.2

2022-11-17 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
doru1004 closed this revision. doru1004 added a comment. Commit: 98bfd7f976f166e2eb7b444f3ee86843815ca73c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138159/new/ https://revie

[PATCH] D138159: [Clang][OpenMP] Add enter clause to declare target for OpenMP 5.2

2022-11-17 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
doru1004 updated this revision to Diff 476143. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138159/new/ https://reviews.llvm.org/D138159 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticParseKinds.td clang/lib/AST/

[PATCH] D138159: [Clang][OpenMP] Add enter clause to declare target for OpenMP 5.2

2022-11-17 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138159/new/ https://reviews.llvm.org/D138159 ___

[PATCH] D138159: [Clang][OpenMP] Add enter clause to declare target for OpenMP 5.2

2022-11-17 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
doru1004 marked 2 inline comments as done. doru1004 added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:1811 + // clause. + if (getLangOpts().OpenMP >= 52 && ClauseName.str() == "to") { +Diag(Tok, diag::err_omp_declare_target_unexpected_to_clause)

[PATCH] D138159: [Clang][OpenMP] Add enter clause to declare target for OpenMP 5.2

2022-11-17 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
doru1004 updated this revision to Diff 476130. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138159/new/ https://reviews.llvm.org/D138159 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticParseKinds.td clang/lib/AST/

[PATCH] D138159: [Clang][OpenMP] Add enter clause to declare target for OpenMP 5.2

2022-11-16 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:1811 + // clause. + if (getLangOpts().OpenMP >= 52 && ClauseName.str() == "to") { +Diag(Tok, diag::err_omp_declare_target_unexpected_to_clause); Do you really need `.str(

[PATCH] D138159: [Clang][OpenMP] Add enter clause to declare target for OpenMP 5.2

2022-11-16 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
doru1004 created this revision. doru1004 added reviewers: carlo.bertolli, ronl, jdoerfert, gregrodgers, dhruvachak. doru1004 added a project: OpenMP. Herald added subscribers: guansong, yaxunl. Herald added a reviewer: aaron.ballman. Herald added a project: All. doru1004 requested review of this r