This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG62f20f51ce39: [PowerPC] Support test data class intrinsic of
128-bit float (authored by qiucf).
Changed prior to commit:
https://reviews.llvm.org/
shchenz accepted this revision as: shchenz.
shchenz added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138105/new/
https://reviews.llvm.org/D138105
qiucf updated this revision to Diff 477375.
qiucf added a comment.
Change error message regarding `__float128`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138105/new/
https://reviews.llvm.org/D138105
Files:
clang/include/clang/Basic/Diagnosti
shchenz added a comment.
The error message needs to be updated too:
def err_ppc_invalid_test_data_class_type : Error<
"expected a 'float' or 'double' for the first argument">;
And can we add a test case for ibm float128 in the clang?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE L
qiucf created this revision.
qiucf added reviewers: nemanjai, shchenz, PowerPC, quinnp, stefanp.
Herald added subscribers: kbarton, hiraditya.
Herald added a project: All.
qiucf requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commit
