Re: [PATCH] D13810: Replacements in different files do not overlap.

angelgarcia updated this revision to Diff 37603. angelgarcia added a comment. In both files. http://reviews.llvm.org/D13810 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp test/clang-tidy/Inputs/overlapping/ test/clang-tidy/Inputs/overlapping/o.h test/clang-tidy/overlapping.cpp Index

Re: [PATCH] D13810: Replacements in different files do not overlap.

This revision was automatically updated to reflect the committed changes. Closed by commit rL250523: Replacements in different files do not overlap. (authored by angelgarcia). Changed prior to commit: http://reviews.llvm.org/D13810?vs=37603&id=37604#toc Repository: rL LLVM http://reviews.ll

Re: [PATCH] D13810: Replacements in different files do not overlap.

angelgarcia updated this revision to Diff 37602. angelgarcia added a comment. Use "not" instead of "!". http://reviews.llvm.org/D13810 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp test/clang-tidy/Inputs/overlapping/ test/clang-tidy/Inputs/overlapping/o.h test/clang-tidy/overlapping

Re: [PATCH] D13810: Replacements in different files do not overlap.

bkramer accepted this revision. bkramer added a reviewer: bkramer. bkramer added a comment. test looks good too, thanks! http://reviews.llvm.org/D13810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: [PATCH] D13810: Replacements in different files do not overlap.

angelgarcia updated this revision to Diff 37600. angelgarcia added a comment. Add a test. http://reviews.llvm.org/D13810 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp test/clang-tidy/Inputs/overlapping/ test/clang-tidy/Inputs/overlapping/o.h test/clang-tidy/overlapping.cpp Index: t

Re: [PATCH] D13810: Replacements in different files do not overlap.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D13810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D13810: Replacements in different files do not overlap.

bkramer added a subscriber: bkramer. bkramer added a comment. Is there a way to unittest this? http://reviews.llvm.org/D13810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D13810: Replacements in different files do not overlap.

angelgarcia created this revision. angelgarcia added a reviewer: klimek. angelgarcia added subscribers: cfe-commits, alexfh. Prevent clang-tidy from discarding fixes that are in different files but happen to have the same file offset. http://reviews.llvm.org/D13810 Files: clang-tidy/ClangTidy