[PATCH] D138031: Add clang-tidy check for missing move constructors

mbid added a comment. Hi Nathan, thanks for looking into this. I did indeed not know about the existing check in cppcoreguidelines -- maybe I should've been more suspicious about assuming something so obvious supposedly doesn't exist yet :) But perhaps the replacements could still be integrated

[PATCH] D138031: Add clang-tidy check for missing move constructors

njames93 added a comment. What is the purpose of this check when we have cppcoreguidelines-special-member-functions . Granted that check won't emit replacements, however the replacements that this

[PATCH] D138031: Add clang-tidy check for missing move constructors

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance/missing-move-constructor.rst:6 + +Warns when a class has a copy constructor but not move constructor. + Please synchronize this sentence with Release Notes.

[PATCH] D138031: Add clang-tidy check for missing move constructors

mbid added inline comments. Comment at: clang/include/clang/Lex/Token.h:101 -return is(K1) || is(K2); - } template bool isOneOf(tok::TokenKind K1, Ts... Ks) const { This change is necessary to make `isOneOf` work with a single argument (and also no argu

[PATCH] D138031: Add clang-tidy check for missing move constructors

mbid created this revision. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. mbid requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monore