This revision was automatically updated to reflect the committed changes.
ABataev marked an inline comment as done.
Closed by commit rL255222: [OPENMP] Make -fopenmp to turn on OpenMP support by
default. (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D13802?vs=38374&id=
ABataev marked an inline comment as done.
ABataev added a comment.
Chandler, thank you very much for review!
Comment at: docs/GettingStarted.rst:58-62
@@ -57,1 +57,7 @@
+#. Checkout Libomp (required for OpenMP support) **[Optional]**:
+
+ * ``cd where-you-want-llvm-to-live``
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
Sorry I was a bit slow -- was out when commented in Nov, and was slow catching
back up the past two weeks.
I've done some more testing, and the check-libomp is passing very nicely now!
Hi Hans,
I asked Chandler to look at this once again but seems to me he is very
busy. Maybe you could ping him also?
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
09.12.2015 0:35, Hans Wennborg пишет:
> hans added a comment.
>
> Alexey & Chandler: Is there any o
hans added a comment.
Alexey & Chandler: Is there any ongoing communication here?
It would be great if we could resolve this, or at least figure out what the
status is, before we branch for 3.8 in a month or so.
http://reviews.llvm.org/D13802
___
tstellarAMD resigned from this revision.
tstellarAMD removed a reviewer: tstellarAMD.
tstellarAMD added a comment.
Hans already commented on the release script changes, and I agrre they look
good.
http://reviews.llvm.org/D13802
___
cfe-commits mail
ABataev added a comment.
Chandler, gcc buildbot greenified, tests for clang are fixed. Hans Wennborg
accepted this patch. Could accept this patch?
http://reviews.llvm.org/D13802
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
jhowarth added a comment.
The CMakeLists.txt change cited is in top-level of the clang sources and not in
the llvm top-level.
http://reviews.llvm.org/D13802
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
ABataev added a comment.
In http://reviews.llvm.org/D13802#276755, @hfinkel wrote:
> In http://reviews.llvm.org/D13802#275471, @chandlerc wrote:
>
> > In http://reviews.llvm.org/D13802#274847, @ABataev wrote:
> >
> > > Hi Chandler, thanks for the review.
> > >
> > > In http://reviews.llvm.org/D13
ABataev added a comment.
In http://reviews.llvm.org/D13802#277270, @jhowarth wrote:
> The proposed patches here to change the default behavior of -fopenmp from
> -fopenmp=libgomp to -fopenmp=libomp seem to only handle the configure-based
> build. The following change required to switch over the
jhowarth added a subscriber: jhowarth.
jhowarth added a comment.
The proposed patches here to change the default behavior of -fopenmp from
-fopenmp=libgomp to -fopenmp=libomp seem to only handle the configure-based
build. The following change required to switch over the crake-based build to
def
hfinkel added a comment.
In http://reviews.llvm.org/D13802#275471, @chandlerc wrote:
> In http://reviews.llvm.org/D13802#274847, @ABataev wrote:
>
> > Hi Chandler, thanks for the review.
> >
> > In http://reviews.llvm.org/D13802#272053, @chandlerc wrote:
> >
> > > I've also had one test fail, and
chandlerc added a comment.
In http://reviews.llvm.org/D13802#274847, @ABataev wrote:
> Hi Chandler, thanks for the review.
>
> In http://reviews.llvm.org/D13802#272053, @chandlerc wrote:
>
> > I've also had one test fail, and then start passing for me on Linux (after
> > fixing the above). I hav
hans added a comment.
The release script change looks good to me. Better than good actually; it's a
great improvement :-)
http://reviews.llvm.org/D13802
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
ABataev added reviewers: hans, tstellarAMD.
ABataev updated this revision to Diff 38374.
ABataev marked an inline comment as done.
http://reviews.llvm.org/D13802
Files:
autoconf/configure.ac
configure
docs/GettingStarted.rst
docs/ReleaseProcess.rst
utils/release/test-release.sh
Index:
ABataev marked an inline comment as done.
ABataev added a comment.
Hi Chandler, thanks for the review.
In http://reviews.llvm.org/D13802#272053, @chandlerc wrote:
> Some minor issues below. Also, Hans and Tom should have a glance at the
> release bits of this, I don't know any of that stuff.
>
chandlerc added a comment.
Some minor issues below. Also, Hans and Tom should have a glance at the release
bits of this, I don't know any of that stuff.
Also, there are still some bugs with check-libomp. The immediate one I noticed
was that when i run it in a clean build with enough parallelism
ABataev created this revision.
ABataev added a reviewer: chandlerc.
ABataev added subscribers: hfinkel, fraggamuffin, ejstotzer, cfe-commits,
llvm-commits.
Patch turns on OpenMP support in clang by default after fixing OpenMP buildbots.
http://reviews.llvm.org/D13802
Files:
configure
docs/G
18 matches
Mail list logo
