Re: [PATCH] D137962: [clang][Tooling] Make the filename behaviour consistent

2022-11-15 Thread Kadir Çetinkaya via cfe-commits
oops, should be fixed with eed1f337a1fbf8c1e7e53a6e1d0dfd4eb800aa08 On Tue, Nov 15, 2022 at 1:03 PM Nico Weber via Phabricator < revi...@reviews.llvm.org> wrote: > thakis added a comment. > > This breaks tests on windows: http://45.33.8.238/win/69993/step_7.txt > > Please take a look and revert f

[PATCH] D137962: [clang][Tooling] Make the filename behaviour consistent

2022-11-15 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. This breaks tests on windows: http://45.33.8.238/win/69993/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137962/new/ https://reviews.llvm.org/D137

[PATCH] D137962: [clang][Tooling] Make the filename behaviour consistent

2022-11-15 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae59131d3ef3: [clang][Tooling] Make the filename behaviour consistent (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D137962: [clang][Tooling] Make the filename behaviour consistent

2022-11-15 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 475362. kadircet added a comment. - Drop documentation - Call remove_dots on the common path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137962/new/ https://reviews.llvm.org/D137962 Files: clang/lib/Tooli

[PATCH] D137962: [clang][Tooling] Make the filename behaviour consistent

2022-11-14 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Code change LGTM, i think the doc change should be dropped or reshaped though. Comment at: clang/docs/JSONCompilationDatabase.rst:89 same file, for example if the s

[PATCH] D137962: [clang][Tooling] Make the filename behaviour consistent

2022-11-14 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. Dotdots were removed only when converting a relative path to absolute