[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary added a comment. In D137836#3959759 , @lenary wrote: > In D137836#3959693 , @DavidSpickett > wrote: > >> Looks like tests need updating for that new -1 return value: >> https://lab.llvm.org/buildbot/#/bui

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary added a comment. In D137836#3959693 , @DavidSpickett wrote: > Looks like tests need updating for that new -1 return value: > https://lab.llvm.org/buildbot/#/builders/178/builds/3419 > > That bot builds with threading disabled. Thanks for letting

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

DavidSpickett added a comment. Looks like tests need updating for that new -1 return value: https://lab.llvm.org/buildbot/#/builders/178/builds/3419 That bot builds with threading disabled. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137836/new/

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. lenary marked an inline comment as done. Closed by commit rG3c97f6cab92f: [Support] Move getHostNumPhysicalCores to Threading.h (authored by lenary). Changed prior to

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary marked 3 inline comments as done. lenary added a comment. Going to attempt to land this again today. Comment at: llvm/lib/Support/Threading.cpp:59 if (MaxThreadCount <= 0) MaxThreadCount = 1; if (ThreadsRequested == 0) tmatheson wrote: > It lo

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

tmatheson accepted this revision. tmatheson added a comment. One thought about returning -1 but otherwise LGTM Comment at: llvm/lib/Support/Threading.cpp:59 if (MaxThreadCount <= 0) MaxThreadCount = 1; if (ThreadsRequested == 0) It looks like this is

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary added a subscriber: MaskRay. lenary added a comment. New version, which changes how the move works a bit. I've updated the description with the caveats, so this is now definitely not NFC. I'm looking for re-review, and maybe input from @MaskRay who has made some minor cleanups in this co

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary edited the summary of this revision. lenary updated this revision to Diff 477975. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137836/new/ https://reviews.llvm.org/D137836 Files: clang-tools-extra/clangd/test/Inputs/BenchmarkHeader.h llv

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fhahn added a comment. In D137836#3950883 , @lenary wrote: > In D137836#3950846 , @fhahn wrote: > >> (it looks like this job should have sent an email: >> https://green.lab.llvm.org/green/job/clang-stage1-RA/3203

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary added a comment. In D137836#3950846 , @fhahn wrote: > (it looks like this job should have sent an email: > https://green.lab.llvm.org/green/job/clang-stage1-RA/32031/console) Yeah, sorry, no email. I'll check with colleagues to see if other peopl

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fhahn added a comment. (it looks like this job should have sent an email: https://green.lab.llvm.org/green/job/clang-stage1-RA/32031/console) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137836/new/ https://reviews.llvm.org/D137836 _

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fhahn added a comment. In D137836#3950825 , @lenary wrote: > In D137836#3950815 , @fhahn wrote: > >> Unfortunately it looks like this commit breaks building on ARM64 macOS. I >> reverted the change for now and ad

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary added a comment. In D137836#3950815 , @fhahn wrote: > Unfortunately it looks like this commit breaks building on ARM64 macOS. I > reverted the change for now and added more details on the error in the revert > commit. Thanks for reverting. I had

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fhahn added a comment. Unfortunately it looks like this commit breaks building on ARM64 macOS. I reverted the change for now and added more details on the error in the revert commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137836/new/ https

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5577207d6d3e: [Support] Move getHostNumPhysicalCores to Threading.h (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fpetrogalli accepted this revision. fpetrogalli added a comment. LGTM. Thank you @lenary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137836/new/ https://reviews.llvm.org/D137836 ___ cfe-commits mailing

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary added inline comments. Comment at: llvm/unittests/Support/Host.cpp:33 -class HostTest : public testing::Test { - Triple Host; - -protected: - bool isSupportedArchAndOS() { -// Initially this is only testing detection of the number of -// physical cores, which i

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fpetrogalli added inline comments. Comment at: llvm/unittests/Support/Host.cpp:33 -class HostTest : public testing::Test { - Triple Host; - -protected: - bool isSupportedArchAndOS() { -// Initially this is only testing detection of the number of -// physical cores, wh

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary added inline comments. Comment at: llvm/unittests/Support/Host.cpp:33 -class HostTest : public testing::Test { - Triple Host; - -protected: - bool isSupportedArchAndOS() { -// Initially this is only testing detection of the number of -// physical cores, which i

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary edited the summary of this revision. lenary updated this revision to Diff 477912. lenary marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137836/new/ https://reviews.llvm.org/D137836 Files: clang-tools-extra/c

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fpetrogalli added inline comments. Comment at: llvm/unittests/Support/Host.cpp:33 -class HostTest : public testing::Test { - Triple Host; - -protected: - bool isSupportedArchAndOS() { -// Initially this is only testing detection of the number of -// physical cores, wh

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

tmatheson added a comment. Makes sense since it is so similar to `get_cpus()` and is only used in Threading. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137836/new/ https://reviews.llvm.org/D137836 __

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary created this revision. Herald added subscribers: kadircet, arphaman, hiraditya, krytarowski. Herald added a project: All. lenary requested review of this revision. Herald added projects: LLVM, clang-tools-extra. Herald added subscribers: cfe-commits, llvm-commits. This change is focussed on