This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG29c92879171d: [AST] Fix class layout when using external
layout under MS ABI. (authored by zequanwu).
Changed prior to commit:
https://reviews.llv
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137806/new/
https://reviews.llvm.org/D137806
___
cfe-c
zequanwu added inline comments.
Comment at: clang/test/CodeGenCXX/override-layout-virtual-base.cpp:25-43
+// CHECK: *** Dumping AST Record Layout
+// CHECK-NEXT: 0 | struct S2
+// CHECK-NEXT: 0 | (S2 vftable pointer)
+// CHECK-NEXT: 8 | (S2 vbt
zequanwu created this revision.
zequanwu added a reviewer: rnk.
Herald added a project: All.
zequanwu requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D137806
Files:
clang/li