[PATCH] D137760: Add FP8 E4M3 support to APFloat.

2022-11-15 Thread Reed Wanderman-Milne via Phabricator via cfe-commits
reedwm added a comment. In D137760#3928314 , @stellaraccident wrote: > Thanks for this. Patch lgtm. Has a couple of format issues but probably ok > as-is (this file is very inconsistently formatted and it looks like you > overrode clang-format a bit fo

[PATCH] D137760: Add FP8 E4M3 support to APFloat.

2022-11-15 Thread Benjamin Kramer via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88eb3c62f25d: Add FP8 E4M3 support to APFloat. (authored by reedwm, committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D137760: Add FP8 E4M3 support to APFloat.

2022-11-15 Thread Stella Laurenzo via Phabricator via cfe-commits
stellaraccident accepted this revision. stellaraccident added a comment. Thanks for this. Patch lgtm. Has a couple of format issues but probably ok as-is (this file is very inconsistently formatted and it looks like you overrode clang-format a bit for consistency with adjacent code). Repositor

[PATCH] D137760: Add FP8 E4M3 support to APFloat.

2022-11-15 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137760/new/ https://reviews.llvm.org/D137760 _

[PATCH] D137760: Add FP8 E4M3 support to APFloat.

2022-11-09 Thread Reed Wanderman-Milne via Phabricator via cfe-commits
reedwm created this revision. reedwm added reviewers: stellaraccident, bkramer, rengolin, jpienaar. Herald added subscribers: bzcheeseman, rriddle, hiraditya, kristof.beyls. Herald added a project: All. reedwm requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, s