[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f85c560b43b: [Clang][AIX][p]Enable -p Functionality (authored by francii). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.o

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii updated this revision to Diff 495588. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/A

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii updated this revision to Diff 493054. francii added a comment. Update based on review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Driver/Options.td clang/lib/Dri

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, with small nit to address before commit Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6287-6292 if (!TC.getTriple().isOSAIX() && !TC.getTriple().isOSOpenBS

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:274 -if (Args.hasArg(options::OPT_pg)) { +if (Args.hasArg(options::OPT_p, options::OPT_pg)) { CmdArgs.push_back(Args.MakeArgString((llvm::Twine("-L") + D.SysRoot) + da

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii updated this revision to Diff 492189. francii added a comment. Remove cc1 option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/T

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

daltenty added inline comments. Comment at: clang/include/clang/Driver/Options.td:4141 HelpText<"Warn on language extensions">, MarshallingInfoFlag>; +def p : Flag<["-"], "p">, HelpText<"Enable mcount instrumentation with prof">, Flags<[CC1Option]>; def pg : Flag<["-"], "pg

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii updated this revision to Diff 491444. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/A

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii updated this revision to Diff 491204. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/A

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii updated this revision to Diff 490638. francii added a comment. Specifically check for AIX before pushing pg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Driver/Opti

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii updated this revision to Diff 490261. francii added a comment. Remove codegen option approach Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Driver/Options.td clang

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii updated this revision to Diff 487907. francii added a comment. Add supports profiling check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Basic/CodeGenOptions.def