v1nh1shungry added a comment.
Seems like I have made things too complex :(
Should work for C, C++, and other languages now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137650/new/
https://reviews.llvm.org/D137650
___
v1nh1shungry updated this revision to Diff 474149.
v1nh1shungry added a comment.
Improve the patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137650/new/
https://reviews.llvm.org/D137650
Files:
clang-tools-extra/clangd/Hover.cpp
clang-tools
v1nh1shungry updated this revision to Diff 474147.
v1nh1shungry added a comment.
Support different C++ standards
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137650/new/
https://reviews.llvm.org/D137650
Files:
clang-tools-extra/clangd/Hover.cpp
v1nh1shungry updated this revision to Diff 474117.
v1nh1shungry added a comment.
Improve the patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137650/new/
https://reviews.llvm.org/D137650
Files:
clang-tools-extra/clangd/Hover.cpp
clang-tools
v1nh1shungry added a comment.
@tom-anders Thanks for reviewing and for your suggestions!
Comment at: clang-tools-extra/clangd/Hover.cpp:785
+
+ // TODO: Show string literal's contents
+ HI.Name = "String Literal";
tom-anders wrote:
> Is it really useful to sh
tom-anders added inline comments.
Comment at: clang-tools-extra/clangd/Hover.cpp:785
+
+ // TODO: Show string literal's contents
+ HI.Name = "String Literal";
Is it really useful to show the contents inside the Hover? You already see the
contents of the string
v1nh1shungry created this revision.
v1nh1shungry added reviewers: nridge, tom-anders.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
v1nh1shungry requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: cla
