[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a7be42d922a: [C++20] [Modules] Remove unmaintained Header Module (authored by ChuanqiXu). Herald added a subscriber: MaskRay. Changed prior to commit: https://reviews.llvm.org/D137609?vs=473884&id=4763

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

ChuanqiXu added a comment. Thanks for every one to review this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137609/new/ https://reviews.llvm.org/D137609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Also not using this at Meta, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137609/new/ https://reviews.llvm.org/D137609 ___ cfe-commit

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

ChuanqiXu added a comment. @bruno ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137609/new/ https://reviews.llvm.org/D137609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

dblaikie added a comment. > I'm not aware of anyone using this mode, but please wait for responses from > Google and Meta people to verify that. Best understanding on the Google side is we aren't using this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137609/new/ https://reviews.llv

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

ChuanqiXu added a reviewer: bruno. ChuanqiXu added a comment. In D137609#3915632 , @iains wrote: > I think that (if this change is approved) there will be also some > simplifications possible in the driver (since the mode that produces a > wrapper hea

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

iains added a comment. I think that (if this change is approved) there will be also some simplifications possible in the driver (since the mode that produces a wrapper header for multiple command-line headers is different from the mode where multiple command line headers would each produce a si

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

Bigcheese added a comment. I'm not aware of anyone using this mode, but please wait for responses from Google and Meta people to verify that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137609/new/ https://reviews.llvm.org/D137609 ___ cfe-

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

ChuanqiXu updated this revision to Diff 473884. ChuanqiXu added a comment. Remove other logics. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137609/new/ https://reviews.llvm.org/D137609 Files: clang/include/clang/Frontend/FrontendActions.h clang/include/clang/Frontend/FrontendOpti

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

ChuanqiXu created this revision. ChuanqiXu added reviewers: rsmith, iains, dblaikie, Bigcheese. ChuanqiXu added a project: clang-modules. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently there