[PATCH] D137578: Fix 'unsafe-math-optimizations' flag dependencies

2022-11-11 Thread Zahira Ammarguellat via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91628f0616ca: The handling of 'funsafe-math-optimizations' doesn't update the 'MathErrno' (authored by zahiraam). Changed prior to commit: https:

[PATCH] D137578: Fix 'unsafe-math-optimizations' flag dependencies

2022-11-10 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale accepted this revision. michele.scandale added a comment. This revision is now accepted and ready to land. This looks good for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137578/new/ https://reviews.llvm.org/D137578

[PATCH] D137578: Fix 'unsafe-math-optimizations' flag dependencies

2022-11-10 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam added a comment. In D137578#3918314 , @michele.scandale wrote: > Looks good to me @michele.scandale Now that I opened up the patch to all, it needs another stamp from you. Would you mind reviewing it again please? I will wait for a day before

[PATCH] D137578: Fix 'unsafe-math-optimizations' flag dependencies

2022-11-10 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3957 - if (Arg *A = Args.getLastArg(OPT_ffp_contract)) { -StringRef Val = A->getValue(); -if (Val == "fast") + if (auto *A = Args.getLastArg(OPT_ffp_contract, OPT_cl_fast_relaxed_mat

[PATCH] D137578: Fix 'unsafe-math-optimizations' flag dependencies

2022-11-10 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam updated this revision to Diff 474515. zahiraam edited the summary of this revision. zahiraam added reviewers: andrew.w.kaylor, michele.scandale. zahiraam set the repository for this revision to rG LLVM Github Monorepo. zahiraam changed the visibility from "Custom Policy" to "All Users". za