This revision was automatically updated to reflect the committed changes.
Closed by commit rG82ca918b5755: [clangd] Fix the code action
`RemoveUsingNamespace` (authored by v1nh1shungry, committed by tom-anders).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.ll
v1nh1shungry updated this revision to Diff 474262.
v1nh1shungry added a comment.
Format codes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137550/new/
https://reviews.llvm.org/D137550
Files:
clang-tools-extra/clangd/refactor/tweaks/RemoveUsingN
v1nh1shungry added a comment.
@tom-anders Thanks for reviewing and for your suggestions!
I think your suggestion is excellent, but for now, it is too complex for me to
implement.
If this patch is okay, could you please help me commit it? Thanks again!
Repository:
rG LLVM Github Monorepo
CH
v1nh1shungry updated this revision to Diff 474127.
v1nh1shungry added a comment.
Improve the patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137550/new/
https://reviews.llvm.org/D137550
Files:
clang-tools-extra/clangd/refactor/tweaks/RemoveU
tom-anders accepted this revision.
tom-anders added a comment.
This revision is now accepted and ready to land.
Would be cool if in the future we could instead transform something like
using namespace std;
int main() {
auto t = 5ms;
}
into
using namespace std::chrono_literals;
in
v1nh1shungry created this revision.
v1nh1shungry added reviewers: tom-anders, sammccall.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
v1nh1shungry requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project:
