[PATCH] D137531: [clang] Fix the GitHub issue #58674

2022-11-07 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. Thanks for working on this. I agree with Aaron, can you make the commit message clearer as to what is fixed, and mention in clang/docs/ReleaseNotes that the issue is fixed. Comment at: clang/lib/Sema/SemaExpr.cpp:2698-2704 + if (!SS.isEmpty()) +

[PATCH] D137531: [clang] Fix the GitHub issue #58674

2022-11-07 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a reviewer: clang-language-wg. aaron.ballman added a comment. FWIW, it'd help reviewers out if you would use a more descriptive title for the patch than just the GitHub issue number (it's easier for us to keep reviews straight when they have more concrete titles). I made a qu