[PATCH] D137524: clang/AMDGPU: Emit atomicrmw for atomic_inc/dec builtins

arsenm closed this revision. arsenm added a comment. b84721df636747a9955408a934e713192a9cfe21 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137524/new/ https://reviews.llvm.org/D137524 __

[PATCH] D137524: clang/AMDGPU: Emit atomicrmw for atomic_inc/dec builtins

pravinjagtap accepted this revision as: pravinjagtap. pravinjagtap added a comment. LGTM, In the context of atomic optimizer, when we extend the support for `atomicInc` and `atomicDec`, I think, the visitor of AtomicRMWInst will find the potential candidate for optimization now instead of visito

[PATCH] D137524: clang/AMDGPU: Emit atomicrmw for atomic_inc/dec builtins

yaxunl accepted this revision as: yaxunl. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137524/new/ https://reviews.llvm.org/D137524 ___ cfe-commits mailing

[PATCH] D137524: clang/AMDGPU: Emit atomicrmw for atomic_inc/dec builtins

arsenm added a comment. Herald added a subscriber: arichardson. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137524/new/ https://reviews.llvm.org/D137524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D137524: clang/AMDGPU: Emit atomicrmw for atomic_inc/dec builtins

foad added a comment. In D137524#3911439 , @JonChesterfield wrote: > Do you know where the uinc_wrap etc were introduced? D137361 in the stack for this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137

[PATCH] D137524: clang/AMDGPU: Emit atomicrmw for atomic_inc/dec builtins

JonChesterfield added a comment. I don't recognize atomicrmw udec_wrap and can't find it in https://llvm.org/docs/LangRef.html#atomicrmw-instruction. I do vaguely recall the semantics of these builtins (well, the instructions they target) being surprising, Do you know where the uinc_wrao etc we

[PATCH] D137524: clang/AMDGPU: Emit atomicrmw for atomic_inc/dec builtins

arsenm created this revision. arsenm added reviewers: yaxunl, AMDGPU. Herald added subscribers: kosarev, Anastasia, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. This makes the scope and ordering arguments