[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG54178fc6161a: [clang-tidy] add check for capturing lambda coroutines (authored by dotnwat, committed by PiotrZSL). Reposi

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM. Thanks! BTW, in such cases, you can commandeer the revision generally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137514/new/ https://reviews.llvm.org/D137514 __

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

PiotrZSL updated this revision to Diff 503939. PiotrZSL added a comment. Making tests passing on this diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137514/new/ https://reviews.llvm.org/D137514 Files: clang-tools-extra/clang-tidy/cppcoregui

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

PiotrZSL updated this revision to Diff 503888. PiotrZSL added a comment. Rebase + Move files to other locations due to structure change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137514/new/ https://reviews.llvm.org/D137514 Files: clang-tool

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

ChuanqiXu added a comment. Herald added a subscriber: PiotrZSL. Is there any new progress on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137514/new/ https://reviews.llvm.org/D137514 ___ cfe-commi

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCapturingLambdaCoroutinesCheck.cpp:40 + + diag(Lambda->getBeginLoc(), "found capturing coroutine lambda"); +} carlosgalvezp wrote: > Perhaps it would be good wi

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

carlosgalvezp requested changes to this revision. carlosgalvezp added a comment. This revision now requires changes to proceed. Looking good! Some minor comments Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCapturingLambdaCoroutinesCheck.cpp:40 + + diag(Lam

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

ChuanqiXu added a comment. In D137514#3912626 , @dotnwat wrote: > In D137514#3911046 , @ChuanqiXu > wrote: > >> This is helpful. I feel it is OK to add the warning in the clang too. Are >> you interested in that

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

dotnwat added a comment. In D137514#3911046 , @ChuanqiXu wrote: > This is helpful. I feel it is OK to add the warning in the clang too. Are you > interested in that? Yes, but unfortunately I'm very time constrained until the end of the year. Is that so

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

ChuanqiXu added a comment. This is helpful. I feel it is OK to add the warning in the clang too. Are you interested in that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137514/new/ https://reviews.llvm.org/D137514 __

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

dotnwat created this revision. Herald added subscribers: carlosgalvezp, ChuanqiXu, kbarton, xazax.hun, nemanjai. Herald added a project: All. dotnwat requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Signed-off-by: Noah Watkins