[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5a2ef80fa47: [clangd] Fix the code action `RemoveUsingNamespace` (authored by v1nh1shungry, committed by tom-anders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry added a comment. In D137494#3910598 , @tom-anders wrote: > Thanks for the fix, LGTM! Do you want me to commit this for you? Yes! Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

tom-anders accepted this revision. tom-anders added a comment. This revision is now accepted and ready to land. Thanks for the fix, LGTM! Do you want me to commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137494/new/ https://revie

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry updated this revision to Diff 473480. v1nh1shungry added a comment. Format codes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137494/new/ https://reviews.llvm.org/D137494 Files: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingN

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry added a comment. @junaire Thank you for reviewing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137494/new/ https://reviews.llvm.org/D137494 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

junaire added inline comments. Comment at: clang-tools-extra/clangd/unittests/tweaks/RemoveUsingNamespaceTests.cpp:236 + } + using namespace n^s; + int main() { v1nh1shungry wrote: > junaire wrote: > > is this a typo? > I guess not. I refer to the

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry added inline comments. Comment at: clang-tools-extra/clangd/unittests/tweaks/RemoveUsingNamespaceTests.cpp:236 + } + using namespace n^s; + int main() { junaire wrote: > is this a typo? I guess not. I refer to the tests above and I th

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry added a comment. In D137494#3910500 , @v1nh1shungry wrote: > @tom-anders Thank you for reviewing! > > I tried adding a test but I don't know how to run the tests. > > And I just found that operators declared in a class context are already >

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

junaire added a comment. In D137494#3910500 , @v1nh1shungry wrote: > @tom-anders Thank you for reviewing! > > I tried adding a test but I don't know how to run the tests. > > And I just found that operators declared in a class context are already > hand

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry updated this revision to Diff 473478. v1nh1shungry added a comment. Correct the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137494/new/ https://reviews.llvm.org/D137494 Files: clang-tools-extra/clangd/refactor/tweaks/RemoveUs

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry added a comment. @tom-anders Thank you for reviewing! I tried adding a test but I don't know how to run the tests. And I just found that operators declared in a class context are already handled in the existing version, but user-defined literals are not, so I rewrote the comments.

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry updated this revision to Diff 473477. v1nh1shungry added a comment. Correct the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137494/new/ https://reviews.llvm.org/D137494 Files: clang-tools-extra/clangd/refactor/tweaks/RemoveUs

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry updated this revision to Diff 473475. v1nh1shungry added a comment. Add a test and rewrite the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137494/new/ https://reviews.llvm.org/D137494 Files: clang-tools-extra/clangd/refact

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

tom-anders requested changes to this revision. tom-anders added a comment. This revision now requires changes to proceed. Did a quick test on my machine, seems to work! Can you add a regression test to clang-tools-extra/clangd/unittests/tweaks/RemoveUsingNamespaceTests.cpp though? Repository:

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry created this revision. v1nh1shungry added reviewers: thesamesam, tom-anders, junaire. Herald added subscribers: kadircet, arphaman. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a