[PATCH] D137488: [clang][Interp] Array initialization via string literal

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a3243de62c1: [clang][Interp] Array initialization via string literal (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D13

[PATCH] D137488: [clang][Interp] Array initialization via string literal

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. This looks good to me now. I'm sorry for taking so long to return to review. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1098-1099 + +unsigned N = SL->

[PATCH] D137488: [clang][Interp] Array initialization via string literal

tbaeder added a comment. @tahonermann Anything still missing here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137488/new/ https://reviews.llvm.org/D137488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D137488: [clang][Interp] Array initialization via string literal

tbaeder updated this revision to Diff 477409. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137488/new/ https://reviews.llvm.org/D137488 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AST/Interp/literals.cpp

[PATCH] D137488: [clang][Interp] Array initialization via string literal

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1098-1099 + +unsigned N = SL->getLength(); +for (size_t I = 0; I != NumElems; ++I) { + uint32_t CodePoint = I < N ? SL->getCodeUnit(I) : 0; tbaeder wrote: > tahonerma

[PATCH] D137488: [clang][Interp] Array initialization via string literal

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1098-1099 + +unsigned N = SL->getLength(); +for (size_t I = 0; I != NumElems; ++I) { + uint32_t CodePoint = I < N ? SL->getCodeUnit(I) : 0; tahonermann wrote: > tahon

[PATCH] D137488: [clang][Interp] Array initialization via string literal

tbaeder updated this revision to Diff 476660. tbaeder marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137488/new/ https://reviews.llvm.org/D137488 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AS

[PATCH] D137488: [clang][Interp] Array initialization via string literal

tahonermann added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1098-1099 + +unsigned N = SL->getLength(); +for (size_t I = 0; I != NumElems; ++I) { + uint32_t CodePoint = I < N ? SL->getCodeUnit(I) : 0; tahonermann wrote: > A

[PATCH] D137488: [clang][Interp] Array initialization via string literal

tbaeder updated this revision to Diff 475697. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137488/new/ https://reviews.llvm.org/D137488 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AS

[PATCH] D137488: [clang][Interp] Array initialization via string literal

tahonermann added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1098-1099 + +unsigned N = SL->getLength(); +for (size_t I = 0; I != NumElems; ++I) { + uint32_t CodePoint = I < N ? SL->getCodeUnit(I) : 0; Aren't `N` and `NumEle

[PATCH] D137488: [clang][Interp] Array initialization via string literal

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1133-1134 + } else if (const auto *SL = dyn_cast(Initializer)) { +const ArrayType *AT = SL->getType()->getAsArrayTypeUnsafe(); +const auto *CAT = cast(AT); +size_t NumElems = CAT->get

[PATCH] D137488: [clang][Interp] Array initialization via string literal

tbaeder updated this revision to Diff 474177. tbaeder marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137488/new/ https://reviews.llvm.org/D137488 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AS

[PATCH] D137488: [clang][Interp] Array initialization via string literal

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1133-1134 + } else if (const auto *SL = dyn_cast(Initializer)) { +const ArrayType *AT = SL->getType()->getAsArrayTypeUnsafe(); +const auto *CAT = cast(AT); +size_t NumElems = CA

[PATCH] D137488: [clang][Interp] Array initialization via string literal

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1138 +// FIXME: There is a certain code duplication between here +// and Porgram::createGlobalString(). +const size_t CharWidth = SL->getCharByteWidth(); tschuett wr

[PATCH] D137488: [clang][Interp] Array initialization via string literal

tschuett added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1138 +// FIXME: There is a certain code duplication between here +// and Porgram::createGlobalString(). +const size_t CharWidth = SL->getCharByteWidth(); tschuett w

[PATCH] D137488: [clang][Interp] Array initialization via string literal

tschuett added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1138 +// FIXME: There is a certain code duplication between here +// and Porgram::createGlobalString(). +const size_t CharWidth = SL->getCharByteWidth(); Program

[PATCH] D137488: [clang][Interp] Array initialization via string literal

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revi