This revision was automatically updated to reflect the committed changes.
carlosgalvezp marked an inline comment as done.
Closed by commit rG65d6d67fc9a9: [clang-tidy] Add misc-use-anonymous-namespace
check (authored by carlosgalvezp).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACT
bigdavedev accepted this revision.
bigdavedev added a comment.
This revision is now accepted and ready to land.
Looks good to me. All comments/suggestions/concerns addressed.
Comment at:
clang-tools-extra/docs/clang-tidy/checks/misc/use-anonymous-namespace.rst:7-9
+that could
carlosgalvezp marked an inline comment as done.
carlosgalvezp added inline comments.
Comment at:
clang-tools-extra/docs/clang-tidy/checks/misc/use-anonymous-namespace.rst:7-9
+that could instead be moved into an anonymous namespace. It also detects
+instances moved to an anonymo
bigdavedev added inline comments.
Comment at:
clang-tools-extra/docs/clang-tidy/checks/misc/use-anonymous-namespace.rst:7-9
+that could instead be moved into an anonymous namespace. It also detects
+instances moved to an anonymous namespace that still keep the redundant
+``stati
carlosgalvezp updated this revision to Diff 478603.
carlosgalvezp added a comment.
Replace "the" anonymous namespace with "an" anonymous namespace
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137340/new/
https://reviews.llvm.org/D137340
F
carlosgalvezp added a comment.
Another week, another ping @njames93 @aaron.ballman
I have addressed all comments since 3 weeks ago, and have not received any
objections. I intend to land this patch next week (1st December) if I don't
receive any further feedback.
Repository:
rG LLVM Github
carlosgalvezp added a comment.
@njames93 Ping again. Alternatively, could someone else review? @aaron.ballman
maybe?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137340/new/
https://reviews.llvm.org/D137340
__
carlosgalvezp added a comment.
@njames93 Friendly ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137340/new/
https://reviews.llvm.org/D137340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
carlosgalvezp updated this revision to Diff 473494.
carlosgalvezp added a comment.
Simplify code for printing the type of the declaration.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137340/new/
https://reviews.llvm.org/D137340
Files:
clang-to
carlosgalvezp updated this revision to Diff 473214.
carlosgalvezp added a comment.
Fix typo in binding names
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137340/new/
https://reviews.llvm.org/D137340
Files:
clang-tools-extra/clang-tidy/misc/CMak
carlosgalvezp updated this revision to Diff 473211.
carlosgalvezp added a comment.
Remove some code duplication
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137340/new/
https://reviews.llvm.org/D137340
Files:
clang-tools-extra/clang-tidy/misc/C
carlosgalvezp updated this revision to Diff 473159.
carlosgalvezp retitled this revision from "[clang-tidy] Add
modernize-use-anonymous-namespace check" to "[clang-tidy] Add
misc-use-anonymous-namespace check".
carlosgalvezp added a comment.
Update commit message
Repository:
rG LLVM Github M
12 matches
Mail list logo
