This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGaa99b607b5cf: [clang][pdb] Don't include
-fmessage-length in PDB buildinfo (authored by thieta).
Repository:
rG LLVM Github Monorepo
CHANGES SINC
thieta added a comment.
Thanks @hans
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137322/new/
https://reviews.llvm.org/D137322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.
thieta updated this revision to Diff 473912.
thieta added a comment.
Updated from feedback
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137322/new/
https://reviews.llvm.org/D137322
Files:
clang/test/CodeGen/debug-info-codeview-buildinfo.c
llv
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm with nits
Comment at: clang/test/CodeGen/debug-info-codeview-buildinfo.c:47
+// MESSAGELEN: 0x{{.+}} | LF_BUILDINFO [size = {{.+}}]
+// MESSAGELEN-NOT: 0x{{.+}}: `"
thieta added a reviewer: hans.
thieta added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137322/new/
https://reviews.llvm.org/D137322
___
cfe-commits mailing list
cfe-commits@lists.llvm.
thieta created this revision.
thieta added reviewers: aganea, rnk, thakis, aeubanks.
Herald added a subscriber: hiraditya.
Herald added a project: All.
thieta requested review of this revision.
Herald added projects: clang, LLVM.
Herald added a subscriber: cfe-commits.
As discussed in https://revi
