This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rGf3e8a117d2bc: [include-cleaner] Add export IWYU pragma
support. (authored by hokein).
Changed prior to comm
hokein marked 2 inline comments as done.
hokein added inline comments.
Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:84
+Out->IWYUExportBy[IncludedHeader->getUniqueID()].push_back(
+save(SM.getFileEntryForID(Top.SeenAtFile)->tryGetRealPathName()
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks for bearing with me, LG!
Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:72
+ void checkForExport(FileID FileSeenHash, int HashLine,
+
hokein updated this revision to Diff 474505.
hokein marked 8 inline comments as done.
hokein added a comment.
address remaining comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137319/new/
https://reviews.llvm.org/D137319
Files:
clang-too
kadircet added inline comments.
Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:69
+ // main-file #include with export pragma should never be removed.
+ if (Top.Exporter == SM.getMainFileID())
+Out->ShouldKeep.insert(
hokein wrote:
hokein added inline comments.
Comment at:
clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:82
+ llvm::DenseMap>
+ IWYUExportBy;
kadircet wrote:
> kadircet wrote:
> > what about a smallvector, instead of a denseset here?
> nit: inste
hokein updated this revision to Diff 473174.
hokein marked 7 inline comments as done.
hokein added a comment.
Herald added a subscriber: mgrang.
address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137319/new/
https://reviews.llvm.
kadircet added inline comments.
Comment at:
clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:82
+ llvm::DenseMap>
+ IWYUExportBy;
what about a smallvector, instead of a denseset here?
Comment at:
clang-tools-extr
hokein created this revision.
hokein added reviewers: kadircet, sammccall.
Herald added a project: All.
hokein requested review of this revision.
Herald added a project: clang-tools-extra.
- add support to PragmaIncludes to handle IWYU export/begin_exports/end_exports
pragma;
- implement an API t
