[PATCH] D137317: [X86][CET] Add Diags for targets pre to i686 for `-fcf-protection`

This revision was automatically updated to reflect the committed changes. Closed by commit rG525167829727: [X86][CET] Add Diags for targets pre to i686 for `-fcf-protection` (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137317/

[PATCH] D137317: [X86][CET] Add Diags for targets pre to i686 for `-fcf-protection`

pengfei added a comment. Thanks @nickdesaulniers and @craig.topper! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137317/new/ https://reviews.llvm.org/D137317 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D137317: [X86][CET] Add Diags for targets pre to i686

nickdesaulniers added a comment. In D137317#3905654 , @craig.topper wrote: > In D137317#3905643 , > @nickdesaulniers wrote: > >> Seems fine, though looking at `llvm::X86::CPUKind`, why do you choose >> `llvm::X

[PATCH] D137317: [X86][CET] Add Diags for targets pre to i686

craig.topper added a comment. In D137317#3905643 , @nickdesaulniers wrote: > Seems fine, though looking at `llvm::X86::CPUKind`, why do you choose > `llvm::X86::CK_PentiumPro` as the lower bounds? Surely > `llvm::X86::CK_Pentium2` doesn't support CET?

[PATCH] D137317: [X86][CET] Add Diags for targets pre to i686

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Seems fine, though looking at `llvm::X86::CPUKind`, why do you choose `llvm::X86::CK_PentiumPro` as the lower bounds? Surely `llvm::X86::CK_Pentium2` doesn't support CET? Do

[PATCH] D137317: [X86][CET] Add Diags for targets pre to i686

pengfei updated this revision to Diff 472916. pengfei added a comment. Fix lit fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137317/new/ https://reviews.llvm.org/D137317 Files: clang/lib/Basic/Targets/X86.h Index: clang/lib/Basic/Targets

[PATCH] D137317: [X86][CET] Add Diags for targets pre to i686

pengfei created this revision. pengfei added a reviewer: nickdesaulniers. Herald added a project: All. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I intended to not adding test case since it is NFC to most modern X86 targets. F