[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

ronlieb added a comment. [AMD Official Use Only - General] Please look into AMDGPU bot fail https://lab.llvm.org/buildbot/#/builders/193/builds/21319 Get Outlook for iOShttps://aka.ms/o0ukef From: Jennifer Yu via Phabricator Sent: Friday, November 4, 2022 5:40

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

jyu2 closed this revision. jyu2 added a comment. de14befa7730093ff3d46c7628fa1084f251e98d Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137313/new/ https://reviews.llvm.org/D137

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

tianshilei1992 added a comment. nit: this doesn't look like NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137313/new/ https://reviews.llvm.org/D137313 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137313/new/ https://reviews.llvm.org/D137313 ___

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

jyu2 updated this revision to Diff 473084. jyu2 added a comment. Herald added a subscriber: openmp-commits. Thanks Alexey. New runtime test is added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137313/new/ https://reviews.llvm.org/D137313 Files

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

ABataev added a comment. In D137313#3906527 , @jyu2 wrote: > In D137313#3906487 , @ABataev wrote: > >> Do we have a runtime test for this? Would be good to try to test it if the >> offloading fails and the host v

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

jyu2 added a comment. In D137313#3906487 , @ABataev wrote: > Do we have a runtime test for this? Would be good to try to test it if the > offloading fails and the host version is executed instead. I have runtime test in https://reviews.llvm.org/D134268

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

ABataev added a comment. Do we have a runtime test for this? Would be good to try to test it if the offloading fails and the host version is executed instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137313/new/ https://reviews.llvm.org/D1373

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

jyu2 added a comment. In D137313#3904805 , @ABataev wrote: > Whyt it is NFC? I assume it fixes the dereferencing of references, right? Thanks Alexey. I really don't expect run time change for this change. The change only change BP/PP of the map inste

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

ABataev added a comment. Whyt it is NFC? I assume it fixes the dereferencing of references, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137313/new/ https://reviews.llvm.org/D137313 ___ cfe-commi

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

jyu2 created this revision. jyu2 added reviewers: abhinavgaba, ABataev, mikerice. jyu2 added a project: OpenMP. Herald added a project: All. jyu2 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. I