pgousseau updated this revision to Diff 38438.
pgousseau added a comment.
Following Anna's review:
Remove unnecessary AST walk over declarations by reusing already captured
declarations.
Add handling of merge conflicts using Sema merge methods.
Add condition at the end of ModelInjector::onBodySy
pgousseau added inline comments.
Comment at: lib/Analysis/BodyFarm.h:43
@@ +42,3 @@
+ /// \brief Merge the attributes found in model files.
+ /// Note, this adds all attributes found in the model file without any sanity
+ /// checks.
zaks.anna wrote:
> Why do w
zaks.anna added inline comments.
Comment at: lib/Analysis/BodyFarm.h:43
@@ +42,3 @@
+ /// \brief Merge the attributes found in model files.
+ /// Note, this adds all attributes found in the model file without any sanity
+ /// checks.
Why do we not have sanity c
pgousseau updated this revision to Diff 37765.
pgousseau added a comment.
Following Gabor's review:
Remove changes to UncheckedReturn checker.
Add a test using the NonNullParamChecker checker.
Abstract the origin of the attributes.
An analyzer option "faux-attributes" is added. This is 'false' b
pgousseau added a comment.
In http://reviews.llvm.org/D13731#267905, @xazax.hun wrote:
> Hi!
Hi! Thank you for reviewing.
> I have some high level questions and notes about this patch.
>
> I implemented the function modelling as a Google Summer of Code project and
> Ted Kremenek was my men
xazax.hun added reviewers: krememek, zaks.anna, dcoughlin.
xazax.hun added a comment.
Hi!
I have some high level questions and notes about this patch.
I implemented the function modelling as a Google Summer of Code project and Ted
Kremenek was my mentor. I am happy that you found an useful appl
pgousseau updated this revision to Diff 37466.
pgousseau added a comment.
Fix incorrect caching of model files declarations.
http://reviews.llvm.org/D13731
Files:
include/clang/Analysis/AnalysisContext.h
include/clang/Analysis/CodeInjector.h
include/clang/StaticAnalyzer/Frontend/FrontendA
pgousseau created this revision.
pgousseau added a subscriber: cfe-commits.
Dear All,
I would like to propose a patch for specifying function attributes in .model
files to be used by the analyzer checkers.
There are a number of checkers (such as UncheckedReturn) that contain hardcoded
list of
