[PATCH] D137258: [clang] Optimize storage and lookup of analyzer options

This revision was automatically updated to reflect the committed changes. Closed by commit rG53a4a2b45bb2: [clang] NFCI: Optimize storage and lookup of analyzer options (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D137258?vs=515455&id=515828#toc Repository: r

[PATCH] D137258: [clang] Optimize storage and lookup of analyzer options

jansvoboda11 added a comment. Sorting at compile-time would be nicer, but I don't have the bandwidth to implement something like that. I'll leave a FIXME in case someone wants to pick it up. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D137258: [clang] Optimize storage and lookup of analyzer options

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I liked the idea of sorting these options at compile time. I think the most dummy sort should work just fine inthis case, as the number of elements are not that large. Do you think worth it

[PATCH] D137258: [clang] Optimize storage and lookup of analyzer options

jansvoboda11 updated this revision to Diff 515455. jansvoboda11 added a comment. This revision is now accepted and ready to land. Move from `llvm::StringSwitch` back to binary search on sorted vector Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137

[PATCH] D137258: [clang] Optimize storage and lookup of analyzer options

jansvoboda11 planned changes to this revision. jansvoboda11 added a comment. In D137258#3947181 , @steakhal wrote: > Are you sure about the speedup? > When I looked at the implementation of the `StringSwitch`, it boiled down to > an `if-else` chain under

[PATCH] D137258: [clang] Optimize storage and lookup of analyzer options

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. BTW the change itself looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137258/new/ https://reviews.llvm.org/D137258

[PATCH] D137258: [clang] Optimize storage and lookup of analyzer options

steakhal added a comment. Are you sure about the speedup? When I looked at the implementation of the `StringSwitch`, it boiled down to an `if-else` chain under the hood. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137258/new/ https://reviews.llv

[PATCH] D137258: [clang] Optimize storage and lookup of analyzer options

jansvoboda11 created this revision. jansvoboda11 added a reviewer: Szelethus. Herald added subscribers: steakhal, manas, ASDenysPetrov, ributzka, dkrupp, donat.nagy, a.sidorin, mgrang, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a project: All. jansvoboda11 requested review of t