This revision was automatically updated to reflect the committed changes.
Closed by commit rGea64e66f7b71: [OPENMP]Initial support for error directive.
(authored by jyu2).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137209/new/
https://reviews.llv
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137209/new/
https://reviews.llvm.org/D137209
___
jyu2 updated this revision to Diff 472707.
jyu2 added a comment.
Fix clang format problem.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137209/new/
https://reviews.llvm.org/D137209
Files:
clang/include/clang-c/Index.h
clang/include/clang/AST/
jyu2 added inline comments.
Comment at: clang/include/clang/AST/StmtOpenMP.h:6229
+/// \endcode
+class OMPErrorDirective : public OMPExecutableDirective {
+ friend class ASTStmtReader;
ABataev wrote:
> final
Sorry, forget that. Changed.
Comme
jyu2 updated this revision to Diff 472640.
jyu2 added a comment.
Thanks Alexey for the review. This is to address his comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137209/new/
https://reviews.llvm.org/D137209
Files:
clang/include/clan
ABataev added inline comments.
Comment at: clang/include/clang/AST/StmtOpenMP.h:6229
+/// \endcode
+class OMPErrorDirective : public OMPExecutableDirective {
+ friend class ASTStmtReader;
final
Comment at: llvm/include/llvm/Frontend/OpenMP/OMP
jyu2 created this revision.
jyu2 added reviewers: ABataev, mikerice.
jyu2 added projects: clang, OpenMP.
Herald added subscribers: steakhal, martong, arphaman, guansong, yaxunl.
Herald added a reviewer: NoQ.
Herald added a project: All.
jyu2 requested review of this revision.
Herald added a reviewe
