[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one

vchuravy added a comment. > We'd need a lot more testing before we can claim to support reusing pipelines. Sure, but moving pass pipeline state into the context makes it much harder to do this kind of testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one

aeubanks added a comment. In D137149#4653381 , @vchuravy wrote: > In D137149#4653308 , @aeubanks > wrote: > >> we don't currently support reusing a pipeline so I'm surprised that you're >> able to share/reuse pi

[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one

vchuravy added a subscriber: loladiro. vchuravy added a comment. In D137149#4653308 , @aeubanks wrote: > we don't currently support reusing a pipeline so I'm surprised that you're > able to share/reuse pipelines without running into any issues In additi

[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one

pchintalapudi added a comment. In D137149#4653308 , @aeubanks wrote: > we don't currently support reusing a pipeline so I'm surprised that you're > able to share/reuse pipelines without running into any issues The way I see it, any pipeline state that c

[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one

aeubanks added a comment. we don't currently support reusing a pipeline so I'm surprised that you're able to share/reuse pipelines without running into any issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137149/new/ https://reviews.llvm.org/D

[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one

vchuravy added a comment. Herald added a subscriber: wangpc. Late to the party here, but passing an `LLVMContext` seems really strange from a JIT perspective. We construct a pipeline that may be run over many modules each of them maybe using a different LLVM Context. Repository: rG LLVM Gith

[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG721f975d3518: Use PassGate from LLVMContext if any otherwise global one (authored by Evgeniy Brevnov ). Repository: rG LLVM Git

[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one

ebrevnov updated this revision to Diff 477706. ebrevnov added a comment. Herald added a project: Flang. Fixed build error in flang/lib/Frontend/FrontendActions.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137149/new/ https://reviews.llvm.org/D

[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. the precommit bot is still complaining that flang/lib/Frontend/FrontendActions.cpp needs to be updated lgtm if the precommit bot doesn't show anything related to this patch Repository:

[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one

ebrevnov updated this revision to Diff 477446. ebrevnov marked an inline comment as done. ebrevnov added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137149/n