[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

tbaeder added a comment. I've seen s390x and AIX builders break here, probably a problem with big-endian machines? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137071/new/ https://reviews.llvm.org/D137071

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

tbaeder added a comment. Really didn't expect this: https://lab.llvm.org/buildbot/#/builders/214/builds/5415 Command Output (stderr): -- + : 'RUN: at line 1' + /scratch/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/bin/clang -cc1 -internal-isystem /scratch/powerllvm/powerllvm

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

This revision was automatically updated to reflect the committed changes. Closed by commit rG490e8214fca4: [clang][Interp] Implement missing compound assign operators (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D137071?vs=474273&id=490444#toc Repository: rG LLVM

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

shafik accepted this revision. shafik added a comment. LGTM Comment at: clang/test/AST/Interp/literals.cpp:553 + static_assert(IntRem(2, 1) == 0, ""); + static_assert(IntRem(9, 7) == 2, ""); + aaron.ballman wrote: > tbaeder wrote: > > aaron.ballman wrote: > >

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

tbaeder marked an inline comment as done. tbaeder added a comment. Can't push this without https://reviews.llvm.org/D135750, since the variables in the test functions are used without being initialized. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137071/new/ https://reviews.llvm.org/

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137071/new/ https://reviews.llvm.org/D137071 ___ cfe-commits mailing list

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:591 + + static_assert(IntDiv(INT_MIN, -1) == 0, ""); + aaron.ballman wrote: > This one should fail for the same reason as `%` Works when repla

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

tbaeder updated this revision to Diff 474273. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137071/new/ https://reviews.llvm.org/D137071 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AST/Interp/literals.cpp =

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:591 + + static_assert(IntDiv(INT_MIN, -1) == 0, ""); + This one should fail for the same reason as `%` Comment at: clang/test/AST/Interp/literals.cpp:553 + st

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

tbaeder added a comment. In D137071#3915565 , @aaron.ballman wrote: > Precommit CI looks to have potentially found something interesting here. There might be one of my local patches missing, but it looks like it's somehow not applying this patch, which

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

tbaeder updated this revision to Diff 474181. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137071/new/ https://reviews.llvm.org/D137071 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AST

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

aaron.ballman added a comment. Precommit CI looks to have potentially found something interesting here. Comment at: clang/test/AST/Interp/literals.cpp:553 + static_assert(IntRem(2, 1) == 0, ""); + static_assert(IntRem(9, 7) == 2, ""); + aaron.ballman wrote: >

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

tbaeder updated this revision to Diff 472503. tbaeder marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137071/new/ https://reviews.llvm.org/D137071 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AST

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:553 + static_assert(IntRem(2, 1) == 0, ""); + static_assert(IntRem(9, 7) == 2, ""); + ``` static_assert(IntRem(9, 0) == 12, ""); // Not constexpr static_assert(IntRem(__INT_MIN_

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

tbaeder updated this revision to Diff 471965. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137071/new/ https://reviews.llvm.org/D137071 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AST/Interp/literals.cpp =

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revi