[PATCH] D137064: [clangd] Fix a semantic-highlighting crash.

2022-10-31 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. hokein marked 2 inline comments as done. Closed by commit rG1258747a59db: [clangd] Fix a semantic-highlighting crash. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D137064?vs=471930&id=471947#toc

[PATCH] D137064: [clangd] Fix a semantic-highlighting crash.

2022-10-31 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:664 bool VisitCXXMemberCallExpr(CXXMemberCallExpr *CE) { -if (isa(CE->getMethodDecl())) { +

[PATCH] D137064: [clangd] Fix a semantic-highlighting crash.

2022-10-31 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Mon