[PATCH] D136942: [C2x] Add test coverage for WG14 N2322

aaron.ballman closed this revision. aaron.ballman added a comment. Committed in f1c9ef311fa677992798d609b0445f1d7311a8f2 (forgot to link the review with the commit message, sorry), thank you for the reviews! CHANGES SINCE LA

[PATCH] D136942: [C2x] Add test coverage for WG14 N2322

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I'm OK with this either way, I think you've proved out the important cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136942/new/ https://reviews.llvm.org/D136942 ___

[PATCH] D136942: [C2x] Add test coverage for WG14 N2322

aaron.ballman added inline comments. Comment at: clang/test/C/C2x/n2322.c:44 + ) == 2007); +} + erichkeane wrote: > I might suggest: > > _Static_assert(555 == __\ > LI\ > NE\ > __) > > Which, is basically exactly what the first bullet point in J.1 is trying to

[PATCH] D136942: [C2x] Add test coverage for WG14 N2322

aaron.ballman updated this revision to Diff 471554. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Added an additional test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136942/new/ https://reviews.llvm.org/D136942 Files: clang/test/C/C2x/n2322.c

[PATCH] D136942: [C2x] Add test coverage for WG14 N2322

erichkeane added a comment. I had two suggestions for more tests, but this is probably covering everything. Comment at: clang/test/C/C2x/n2322.c:44 + ) == 2007); +} + I might suggest: _Static_assert(555 == __\ LI\ NE\ __) Which, is basically exactly what the

[PATCH] D136942: [C2x] Add test coverage for WG14 N2322

aaron.ballman created this revision. aaron.ballman added reviewers: clang-language-wg, erichkeane, jyknight. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. The changes in this paper add a new recommended practice. I had originally mark