[PATCH] D136940: [clang][Driver] allow tilde in user config dir

MaskRay added inline comments. Comment at: clang/test/Driver/config-file3.c:227 +// +// RUN: HOME=%S/Inputs/config %clang --config-user-dir=~ -v 2>&1 | FileCheck %s -check-prefix CHECK-TILDE +// CHECK-TILDE: User configuration file directory: {{.*}}/Inputs/config ---

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3f94fe1c3c4: [clang][Driver] allow tilde in user config dir (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136940/new/ https://reviews

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

mgorny added a comment. Ah, I'm sorry for the delay. I have time right now, so I'll test and push it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136940/new/ https://reviews.llvm.org/D136940 ___ cfe-co

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

paperchalice added a comment. Ping @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136940/new/ https://reviews.llvm.org/D136940 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Thanks. I haven't tested it but if it works for you and the test passes, LGTM. @MaskRay, would you be able to test and push it? I don't have a recent clang build tree handy. Repository: rG

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

paperchalice updated this revision to Diff 471717. paperchalice added a comment. Add test on Unix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136940/new/ https://reviews.llvm.org/D136940 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

mgorny requested changes to this revision. mgorny added a comment. This revision now requires changes to proceed. I think you should be able to test it via overriding `HOME` envvar. I suppose you can limit the test to Unix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

MaskRay added a comment. In D136940#3893638 , @paperchalice wrote: > I would appreciate if someone can commit this change. I am waiting on @mgorny 's opinion for https://blogs.gentoo.org/mgorny/2022/10/07/clang-in-gentoo-now-sets-default-runtimes-via-c

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

paperchalice added a comment. I would appreciate if someone can commit this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136940/new/ https://reviews.llvm.org/D136940 ___ cfe-commits mailing list

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

paperchalice added a comment. In D136940#3893391 , @MaskRay wrote: > `clang/test/Driver/config-file3.c` tests `--config-user-dir=` but I cannot > think of a portable way testing this. > `RUN: echo ~; %clang -### --config-user-dir=~ ...` doesn't work as t

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. `clang/test/Driver/config-file3.c` tests `--config-user-dir=` but I cannot think of a portable way testing this. `RUN: echo ~; %clang -### --config-user-dir=~ ...` doesn't work as the selecte

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

paperchalice updated this revision to Diff 471494. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136940/new/ https://reviews.llvm.org/D136940 Files: clang/lib/Driver/Driver.cpp Index: clang/lib/Driver/Driver.cpp =

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

paperchalice created this revision. paperchalice added a reviewer: MaskRay. paperchalice added a project: clang. Herald added a subscriber: StephenFan. Herald added a project: All. paperchalice requested review of this revision. Herald added a subscriber: cfe-commits. This patch allows users to co