This revision was automatically updated to reflect the committed changes.
Closed by commit rG7c50bcb44170: [RISCV] Support -mcpu/mtune=native (authored
by pcwang-thead).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136930/new/
https://reviews.llvm.
pcwang-thead added a comment.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136930/new/
https://reviews.llvm.org/D136930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm
kito-cheng accepted this revision.
kito-cheng added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136930/new/
https://reviews.llvm.org/D136930
___
pcwang-thead updated this revision to Diff 472228.
pcwang-thead added a comment.
- Add release note.
- Add tests to `riscv-cpus.c`.
- Add `getRISCVTargetCPU`.
- Make diagnostic more exact for `native`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D1
craig.topper added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2190
CmdArgs.push_back("-tune-cpu");
-CmdArgs.push_back(A->getValue());
+if (strcmp(A->getValue(), "native") == 0)
+ CmdArgs.push_back(Args.MakeArgString(llvm::sys::getHostCPUN
kito-cheng added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2190
CmdArgs.push_back("-tune-cpu");
-CmdArgs.push_back(A->getValue());
+if (strcmp(A->getValue(), "native") == 0)
+ CmdArgs.push_back(Args.MakeArgString(llvm::sys::getHostCPUNam
kito-cheng added a comment.
Maybe we could add test like aarch64?
https://github.com/llvm/llvm-project/blob/main/clang/test/Driver/aarch64-mcpu.c#L20
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136930/new/
https://reviews.llvm.org/D136930
_
pcwang-thead added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2190
CmdArgs.push_back("-tune-cpu");
-CmdArgs.push_back(A->getValue());
+if (strcmp(A->getValue(), "native") == 0)
+ CmdArgs.push_back(Args.MakeArgString(llvm::sys::getHostCPUN
craig.topper added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2190
CmdArgs.push_back("-tune-cpu");
-CmdArgs.push_back(A->getValue());
+if (strcmp(A->getValue(), "native") == 0)
+ CmdArgs.push_back(Args.MakeArgString(llvm::sys::getHostCPUN
pcwang-thead created this revision.
pcwang-thead added reviewers: kito-cheng, craig.topper, asb.
Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, frasercrmck,
evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl,
jocewei, PkmX, the_o, brucehoult, MartinMosb
10 matches
Mail list logo