tom-anders updated this revision to Diff 472101.
tom-anders marked 3 inline comments as done.
tom-anders added a comment.
Herald added a subscriber: wenlei.
Add test to CodeCompletionTests, only consider unscoped enums in this patch
(move scoped enums to separate patch)
Repository:
rG LLVM Gi
nridge added inline comments.
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:2133
if (const auto *EnumDecl = dyn_cast(ND.getDeclContext()))
-return InTopLevelScope(*EnumDecl) && !EnumDecl->isScoped();
tom-anders wrote:
> nridge wrote:
> > Just to
tom-anders added inline comments.
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:2133
if (const auto *EnumDecl = dyn_cast(ND.getDeclContext()))
-return InTopLevelScope(*EnumDecl) && !EnumDecl->isScoped();
nridge wrote:
> Just to make sure I unders
nridge added inline comments.
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:2133
if (const auto *EnumDecl = dyn_cast(ND.getDeclContext()))
-return InTopLevelScope(*EnumDecl) && !EnumDecl->isScoped();
Just to make sure I understand:
By also remov
tom-anders created this revision.
tom-anders added a reviewer: nridge.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
tom-anders requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
