[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin added a comment. In D136906#3940432 , @WowbaggersLiquidLunch wrote: > In D136906#3940377 , @gonglingqin > wrote: > >> Can you use https://reviews.llvm.org/D138403 to solve this problem? > > Thanks fo

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin added a comment. In D136906#3940427 , @WowbaggersLiquidLunch wrote: >> I get the following error: >> >>> CMake Error: Could not create named generator Xcode > > Sorry, I forgot to mention that Xcode is only available on macOS. > >> But when I

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

WowbaggersLiquidLunch added a comment. In D136906#3940377 , @gonglingqin wrote: > Can you use https://reviews.llvm.org/D138403 to solve this problem? Thanks for letting me know. I'll give it a try. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

WowbaggersLiquidLunch added a comment. > I get the following error: > >> CMake Error: Could not create named generator Xcode Sorry, I forgot to mention that Xcode is only available on macOS. > But when I change Xcode to Ninja, no error output is generated. Indeed. Ninja works fine for me as wel

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin added a comment. In D136906#3940289 , @WowbaggersLiquidLunch wrote: > Hi, this seems to be causing some problems when generating Xcode project. > > When I try to generate the Xcode project with the following command: > > cmake -G "Xcode" -D

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin added a comment. In D136906#3940289 , @WowbaggersLiquidLunch wrote: > Hi, this seems to be causing some problems when generating Xcode project. > > When I try to generate the Xcode project with the following command: > > cmake -G "Xcode" -D

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

WowbaggersLiquidLunch added a comment. Hi, this seems to be causing some problems when generating Xcode project. When I try to generate the Xcode project with the following command: cmake -G "Xcode" -DCMAKE_BUILD_TYPE=Debug -DLLVM_TARGETS_TO_BUILD="X86" -DLLVM_ENABLE_PROJECTS="clang" -DLLVM_O

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85f08c4197ae: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin (authored by gonglingqin). Changed prior to commit: https://reviews.ll

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin updated this revision to Diff 473909. gonglingqin added a comment. Add test cases to detect whether the immediate is out of range. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136906/new/ https://reviews.llvm.org/D136906 Files: clan

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin added inline comments. Comment at: llvm/test/CodeGen/LoongArch/intrinsic-error.ll:10 + +declare void @llvm.loongarch.dbar(i32) SixWeining wrote: > It's better to add a test that immediate is out of range. Thanks, I will add test cases. Repository:

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

SixWeining added inline comments. Comment at: llvm/test/CodeGen/LoongArch/intrinsic-error.ll:10 + +declare void @llvm.loongarch.dbar(i32) It's better to add a test that immediate is out of range. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM but let's wait others. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136906/new/ https://reviews.llvm.org/D136906

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin updated this revision to Diff 473561. gonglingqin added a comment. Address @SixWeining's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136906/new/ https://reviews.llvm.org/D136906 Files: clang/include/clang/Basic/BuiltinsLo

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsLoongArch.td:39 + +def int_loongarch_dbar : Intrinsic<[], [llvm_i32_ty], []>; } // TargetPrefix = "loongarch" SixWeining wrote: > Seems this arg is unnecessary because the defalut valu

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

SixWeining added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsLoongArch.td:39 + +def int_loongarch_dbar : Intrinsic<[], [llvm_i32_ty], []>; } // TargetPrefix = "loongarch" Seems this arg is unnecessary because the defalut value is `[]`. Reposito

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin created this revision. gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. gonglingqin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: l