[PATCH] D136854: [HIP] add -fhiplib-add-rpath

yaxunl updated this revision to Diff 471289. yaxunl added a comment. rename to --offload-add-rpath CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136854/new/ https://reviews.llvm.org/D136854 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Linux.cpp clang/t

[PATCH] D136854: [HIP] add -fhiplib-add-rpath

yaxunl added a comment. In D136854#3889141 , @MaskRay wrote: > If an option does not affect compilation, I prefer `--` to `-f` I will rename it as --offload-add-rpath Comment at: clang/include/clang/Driver/Options.td:4158 + HelpText<

[PATCH] D136854: [HIP] add -fhiplib-add-rpath

MaskRay added a comment. If an option does not affect compilation, I prefer `--` to `-f` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136854/new/ https://reviews.llvm.org/D136854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D136854: [HIP] add -fhiplib-add-rpath

tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:4156 HelpText<"Do not add -rpath with architecture-specific resource directory to the linker flags">; +def fhiplib_add_rpath: Flag<["-"], "fhiplib-add-rpath">, Flags<[NoArgumentUnused]>, + HelpText

[PATCH] D136854: [HIP] add -fhiplib-add-rpath

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: MaskRay. Add an option -f[no-]hiplib-add-rpath to control whether to pass -rpath to linker for HIP runtime library. By default it is off to