This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9308014195e2: [clang][Interp] Diagnose uninitialized array
record fields (authored by tbaeder).
Changed prior to commit:
https://reviews.llvm.org/
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/Interp.cpp:446-448
+static void DiagnoseUninitializedSubobject(InterpState &S, const SourceInfo
&SI,
+ QualType SubObjType,
+ Sourc
tbaeder updated this revision to Diff 473405.
tbaeder marked an inline comment as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136828/new/
https://reviews.llvm.org/D136828
Files:
clang/lib/AST/Interp/Interp.cpp
clang/lib/AST/Interp/Pointer.h
clang/test/AST/Interp/cxx20.cpp
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from the request for a comment about `SourceLocation SL`, this LGTM
(though we may want to improve the diagnostic behavior in the future).
Comment at: cl
tbaeder updated this revision to Diff 471404.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136828/new/
https://reviews.llvm.org/D136828
Files:
clang/lib/AST/Interp/Interp.cpp
clang/lib/AST/Interp/Pointer.h
clang/test/AST/Interp/cxx20.cpp
Index: clang/test/AST/Interp/cxx20.cpp
===
tbaeder marked 3 inline comments as done.
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/Interp.cpp:501
} else if (FieldType->isArrayType()) {
- // FIXME: Arrays need to be handled here as well I think.
+ const ArrayType *AT = FieldType->getAsArray
aaron.ballman added inline comments.
Comment at: clang/lib/AST/Interp/Interp.cpp:446-448
+static void DiagnoseUninitializedSubobject(InterpState &S, const SourceInfo
&SI,
+ QualType SubObjType,
+
